fix(bridge): repair main — axios 1.x mock type and duplicate declaration - #332
Merged
Merged
Conversation
The RPC Relayer Bridge Tests job has been failing on main, which blocks every open PR in this repo. Two causes, both introduced by recently merged work: 1. #327 bumped axios 0.27 -> 1.x, which made `headers` required on `InternalAxiosRequestConfig`. The test mock passed `config: {}`. 2. #321 added an options-aware `disableAtomicVerification` binding but left the older `const disableAtomicVerification = ...` in place, producing a redeclaration error. Kept the newer one — it honours the `options` override and uses `parseBooleanFlag`; the stale line ignored both. Neither surfaced before because the bridge tests only started running in CI when #323 wired them in. All 15 bridge tests pass locally.
|
✅ Vero Security Health Check passed. No findings above severity threshold. |
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainis currently red: the RPC Relayer Bridge Tests job fails, which blocks every open PR in this repo (#331, #330, #329, #328, #322 all inherit it). This restores it.Root cause
Two separate breaks, both from recently merged work, neither visible until #323 wired the bridge tests into CI for the first time:
0.27→1.x. In axios 1.x,headersis required onInternalAxiosRequestConfig; the test mock passedconfig: {}.disableAtomicVerificationbinding but left the olderconst disableAtomicVerification = process.env...in place at line 75 —TS2451: Cannot redeclare block-scoped variable.Changes
headers: new AxiosHeaders(), typed asInternalAxiosRequestConfigoptions.disableAtomicVerificationoverride and usesparseBooleanFlag— the removed line ignored both and read the env var directly.Testing
No behaviour change beyond restoring the intended
optionsprecedence.